Implementation of the ADO.NET batching API#3860
Merged
Merged
Conversation
roji
marked this pull request as draft
June 19, 2021 19:44
roji
force-pushed
the
BatchingAPI
branch
2 times, most recently
from
July 31, 2021 17:50
0a4e8f3 to
cf3f491
Compare
roji
changed the title
roji
marked this pull request as ready for review
July 31, 2021 18:05
Member
Author
|
This is now more or less ready for integration in preview7 - tested against the latest dotnet SDK.
|
vonzshik
reviewed
Aug 15, 2021
vonzshik
left a comment
vonzshik
left a comment
Contributor
There was a problem hiding this comment.
Here we go. Everything looks correct, found a few things which stood out for me from a perf standpoint.
vonzshik
approved these changes
Aug 16, 2021
This was referenced Aug 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.