Skip to content

Avoid blowing stack when checking if a failed dependency is required or optional #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
everett1992 wants to merge 1 commit into from
+6 −2
Closed

Avoid blowing stack when checking if a failed dependency is required or optional #1457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/install/deps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,11 @@ function isDepOptional (tree, name, pkg) {
}

exports.failedDependency = failedDependency
function failedDependency (tree, name, pkg) {
function failedDependency (tree, name, pkg, visited = new Set()) {
// cycle detection
if (visited.has(tree)) return false
visited.add(tree)

if (name) {
if (isDepOptional(tree, name, pkg || {})) {
return false
Expand All @@ -454,7 +458,7 @@ function failedDependency (tree, name, pkg) {
let anyFailed = false
for (var ii = 0; ii < tree.requiredBy.length; ++ii) {
var requireParent = tree.requiredBy[ii]
if (failedDependency(requireParent, moduleName(tree), tree)) {
if (failedDependency(requireParent, moduleName(tree), tree, visited)) {
anyFailed = true
}
}
Expand Down