fix: use name of level instead of label for logging prefixes#7414
Merged
Conversation
lukekarrys
force-pushed
the
lk/log-labels
branch
from
April 24, 2024 21:49
b48958a to
974a91f
Compare
wraithgar
approved these changes
Apr 24, 2024
Merged
This was referenced Apr 25, 2024
Contributor
|
Just a heads up for future explorers and myself - this PR (released in v10.6.0) changed the error log prefix from |
ljharb
referenced
this pull request
in ljharb/aud
May 22, 2024
11 tasks
Apollon77
added a commit
to ioBroker/ioBroker.js-controller
that referenced
this pull request
Jul 17, 2026
…-heal (#3416) * fix(cli): recognise npm >=10.6.0 "npm error" prefix in ENOTEMPTY self-heal handleNpmNotEmptyError() reads the failed destination path from stderr via `startsWith('npm ERR! dest')`. Since npm/cli#7414 (npm v10.6.0) npm prints the log-level name, so the line is `npm error dest ...`. The path is never extracted, the temp-dir deletion + retry is skipped, and the install aborts with "Could not handle ENOTEMPTY, because no deletable files were found". Match both the old and current prefix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Update CHANGELOG.md --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Ingo Fischer <github@fischer-ka.de>
Apollon77
added a commit
to ioBroker/ioBroker.js-controller
that referenced
this pull request
Jul 17, 2026
…l (npm >=10.6.0) (#3417) * fix(cli): treat npm exit-code 1 with an error line as a failed install (npm >=10.6.0) On exit code 1 the install was treated as successful unless result.stderr started with `npm ERR!`. Since npm/cli#7414 (npm v10.6.0) npm prints errors as `npm error`, so on modern npm a genuinely failed install passed the check and, when the target dir already existed (an upgrade), was reported as installed while the old version stayed in place. Also match the current `npm error` prefix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Update CHANGELOG.md --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Ingo Fischer <github@fischer-ka.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.