fix(view): dont immediately exit on first workspace 404

[lukekarrys]

Fixes: #5444

This PR will continue running through all workspaces for npm view even when a workspace encounters an E404 error. This usually happens when you run npm view -ws but have private workspaces. A future iteration could log a different message if an E404 is encountered on a private workspace, but for this PR I wanted to keep it generic since there are a number of reasons a request for a package manifest could 404.

npm view . version -ws

# BEFORE
❯ npm view . version -ws
npm error code E404
npm error 404 Not Found - GET https://registry.npmjs.org/@npmcli%2fdocs - Not found
npm error 404
npm error 404  '@npmcli/docs@*' is not in this registry.
npm error 404
npm error 404 Note that you can also install from a
npm error 404 tarball, folder, http url, or git url.

npm error A complete log of this run can be found in: /Users/lukekarrys/.npm/_logs/2024-05-15T22_04_30_007Z-debug-0.log

# AFTER
❯ npmlocal view . version -ws
@npmcli/docs:
npm error code E404
npm error 404 Not Found - GET https://registry.npmjs.org/@npmcli%2fdocs - Not found
npm error 404
npm error 404  '@npmcli/docs@*' is not in this registry.
npm error 404
npm error 404 Note that you can also install from a
npm error 404 tarball, folder, http url, or git url.
@npmcli/smoke-tests:
npm error code E404
npm error 404 Not Found - GET https://registry.npmjs.org/@npmcli%2fsmoke-tests - Not found
npm error 404
npm error 404  '@npmcli/smoke-tests@*' is not in this registry.
npm error 404
npm error 404 Note that you can also install from a
npm error 404 tarball, folder, http url, or git url.
@npmcli/mock-globals:
npm error code E404
npm error 404 Not Found - GET https://registry.npmjs.org/@npmcli%2fmock-globals - Not found
npm error 404
npm error 404  '@npmcli/mock-globals@*' is not in this registry.
npm error 404
npm error 404 Note that you can also install from a
npm error 404 tarball, folder, http url, or git url.
@npmcli/mock-registry:
npm error code E404
npm error 404 Not Found - GET https://registry.npmjs.org/@npmcli%2fmock-registry - Not found
npm error 404
npm error 404  '@npmcli/mock-registry@*' is not in this registry.
npm error 404
npm error 404 Note that you can also install from a
npm error 404 tarball, folder, http url, or git url.
@npmcli/arborist:
7.5.1
@npmcli/config:
8.3.1
libnpmaccess:
8.0.5
libnpmdiff:
6.1.1
libnpmexec:
8.1.0
libnpmfund:
5.0.9
libnpmhook:
10.0.4
libnpmorg:
6.0.5
libnpmpack:
7.0.1
libnpmpublish:
9.0.7
libnpmsearch:
7.0.4
libnpmteam:
6.0.4
libnpmversion:
6.0.1

npm view . version -ws --json

# BEFORE
❯ npm view . version -ws --json
npm error code E404
npm error 404 Not Found - GET https://registry.npmjs.org/@npmcli%2fdocs - Not found
npm error 404
npm error 404  '@npmcli/docs@*' is not in this registry.
npm error 404
npm error 404 Note that you can also install from a
npm error 404 tarball, folder, http url, or git url.
{
  "error": {
    "code": "E404",
    "summary": "Not Found - GET https://registry.npmjs.org/@npmcli%2fdocs - Not found",
    "detail": "\n '@npmcli/docs@*' is not in this registry.\n\nNote that you can also install from a\ntarball, folder, http url, or git url."
  }
}

npm error A complete log of this run can be found in: /Users/lukekarrys/.npm/_logs/2024-05-15T22_04_55_076Z-debug-0.log

# AFTER
❯ npmlocal view . version -ws --json
{
  "@npmcli/arborist": "7.5.1",
  "@npmcli/config": "8.3.1",
  "libnpmaccess": "8.0.5",
  "libnpmdiff": "6.1.1",
  "libnpmexec": "8.1.0",
  "libnpmfund": "5.0.9",
  "libnpmhook": "10.0.4",
  "libnpmorg": "6.0.5",
  "libnpmpack": "7.0.1",
  "libnpmpublish": "9.0.7",
  "libnpmsearch": "7.0.4",
  "libnpmteam": "6.0.4",
  "libnpmversion": "6.0.1",
  "error": {
    "@npmcli/docs": {
      "code": "E404",
      "summary": "Not Found - GET https://registry.npmjs.org/@npmcli%2fdocs - Not found",
      "detail": "'@npmcli/docs@*' is not in this registry.\n\nNote that you can also install from a\ntarball, folder, http url, or git url."
    },
    "@npmcli/smoke-tests": {
      "code": "E404",
      "summary": "Not Found - GET https://registry.npmjs.org/@npmcli%2fsmoke-tests - Not found",
      "detail": "'@npmcli/smoke-tests@*' is not in this registry.\n\nNote that you can also install from a\ntarball, folder, http url, or git url."
    },
    "@npmcli/mock-globals": {
      "code": "E404",
      "summary": "Not Found - GET https://registry.npmjs.org/@npmcli%2fmock-globals - Not found",
      "detail": "'@npmcli/mock-globals@*' is not in this registry.\n\nNote that you can also install from a\ntarball, folder, http url, or git url."
    },
    "@npmcli/mock-registry": {
      "code": "E404",
      "summary": "Not Found - GET https://registry.npmjs.org/@npmcli%2fmock-registry - Not found",
      "detail": "'@npmcli/mock-registry@*' is not in this registry.\n\nNote that you can also install from a\ntarball, folder, http url, or git url."
    }
  }
}

[npm-cli-bot]

no statistically significant performance changes detected

timing results

app-large	clean	lock-only	cache-only	modules-only	no-lock	no-cache	no-modules	no-clean	show-version	run-script	cache-only peer-deps	no-clean audit
npm@latest	35.077 ±0.00	10.645 ±0.12	11.737 ±0.05	1.539 ±0.00	1.532 ±0.01	1.273 ±0.01	8.185 ±0.02	1.260 ±0.01	0.137 ±0.00	0.164 ±0.00	14.629 ±0.12	2.158 ±0.06
#7508	33.914 ±0.23	10.606 ±0.03	11.669 ±0.04	1.549 ±0.03	1.535 ±0.00	1.266 ±0.01	8.199 ±0.01	1.281 ±0.02	0.138 ±0.00	0.164 ±0.00	14.628 ±0.11	2.156 ±0.01

app-medium	clean	lock-only	cache-only	modules-only	no-lock	no-cache	no-modules	no-clean	show-version	run-script	cache-only peer-deps	no-clean audit
npm@latest	26.882 ±0.74	8.138 ±0.09	9.203 ±0.02	1.530 ±0.01	1.497 ±0.02	1.436 ±0.00	5.877 ±0.02	1.316 ±0.00	0.141 ±0.00	0.174 ±0.00	9.942 ±0.01	2.037 ±0.09
#7508	27.213 ±0.55	8.268 ±0.04	9.160 ±0.04	1.558 ±0.01	1.571 ±0.01	1.484 ±0.01	5.946 ±0.02	1.355 ±0.02	0.141 ±0.00	0.172 ±0.00	9.898 ±0.14	1.978 ±0.05

[lukekarrys]

This also removes the last two istanbul ignore comments in display.js now that this behavior in the view command uses those code paths.