Skip to content

fix(approve-scripts): approve deps with no resolved URL by name#9606

Merged
owlstronaut merged 1 commit into
npm:latestfrom
JamieMagee:fix/approve-scripts-no-resolved-url
Jun 23, 2026
Merged

fix(approve-scripts): approve deps with no resolved URL by name#9606
owlstronaut merged 1 commit into
npm:latestfrom
JamieMagee:fix/approve-scripts-no-resolved-url

Conversation

@JamieMagee

Copy link
Copy Markdown
Contributor

Fixes #9558.

Registry deps with no resolved URL in package-lock.json have no trustable version, so approve-scripts cannot pin them. It was silently writing nothing and leaving them pending; now it approves them by name (pkg: true) and warns why.

@JamieMagee JamieMagee requested review from a team as code owners June 23, 2026 18:41
@owlstronaut owlstronaut merged commit 971500f into npm:latest Jun 23, 2026
31 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🎉 Backport to release/v11 created: #9607

owlstronaut pushed a commit that referenced this pull request Jun 23, 2026
Backport of #9606 to `release/v11`.

Co-authored-by: Jamie Magee <jamie.magee@gmail.com>
@JamieMagee JamieMagee deleted the fix/approve-scripts-no-resolved-url branch June 25, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] "npm approve-scripts --allow-scripts-pending" shows approved depdencies

2 participants