fix(ls): restore 100% coverage on release/v11 after #9633#9636
Merged
owlstronaut merged 1 commit intoJun 24, 2026
Merged
Conversation
Contributor
Author
|
CC: @owlstronaut |
Merged
owlstronaut
approved these changes
Jun 24, 2026
This was referenced Jun 24, 2026
owlstronaut
pushed a commit
that referenced
this pull request
Jun 24, 2026
Restores the global 100% coverage gate on `latest`, which broke after #9626. `filterLinkedStrategyEdges` in `lib/commands/ls.js` skips dev edges on non-root packages — a guard added in #9095 to suppress false `UNMET DEPENDENCY` output in the linked strategy. #9626 fixed the root cause for store packages (they no longer load `devDependencies` as required edges), so the store-based test no longer produces a dev edge, leaving that branch unexercised. Rather than ignore the line, this adds a regression test that genuinely exercises the guard: arborist still loads dev edges for a `file:`-linked transitive package, so listing one with `--all` under the linked strategy reaches the guard at depth > 0 and confirms its devDependency is suppressed instead of reported as `UNMET DEPENDENCY`. The full test suite passes at 100%. This is the `latest` counterpart of #9636, which restored coverage on `release/v11` via an `istanbul ignore`. ## References Follows up #9626
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the global 100% coverage gate on
release/v11, which broke after #9633.filterLinkedStrategyEdgesinlib/commands/ls.jsskips dev edges on non-root (store) packages — a guard added in #9095 to suppress falseUNMET DEPENDENCYoutput in the linked strategy. #9633 fixed the root cause (store packages no longer loaddevDependenciesas required edges), so the test suite no longer produces a store package with a dev edge, leaving that branch unexercised.The guard is kept as defensive (a store package could still carry a dev edge in untested paths) and marked
istanbul ignore, so behavior is unchanged. The full test suite passes at 100%.This gap is invisible on direct pushes to
release/v11because the Test matrix only runs on PRs, so it surfaces on the first PR after #9633.References
Follows up #9633