chore: align tests with nodejs behavior change #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owlstronaut
force-pushed
the
owlstronaut/test-change
branch
from
7af2dfc to
d5fda0e
Compare
wraithgar
changed the title
wraithgar
reviewed
Oct 22, 2025
owlstronaut
force-pushed
the
owlstronaut/test-change
branch
from
d5fda0e to
0dd8faa
Compare
owlstronaut
force-pushed
the
owlstronaut/test-change
branch
from
0dd8faa to
6d81837
Compare
wraithgar
approved these changes
Oct 23, 2025
Member
|
Will we remember to remove this next time we bump engines? Time will tell. |
Merged
owlstronaut
pushed a commit
that referenced
this pull request
Oct 23, 2025
🤖 I have created a release *beep* *boop* --- ## [5.0.0](v4.0.0...v5.0.0) (2025-10-23) ###⚠️ BREAKING CHANGES * `@npmcli/fs` now supports node `^20.17.0 || >=22.9.0` ### Bug Fixes * [`f3b5996`](f3b5996) [#133](#133) align to npm 11 node engine range (@owlstronaut) ### Chores * [`397d379`](397d379) [#135](#135) align tests with nodejs behavior change (@owlstronaut) * [`1be67ee`](1be67ee) [#133](#133) template-oss-apply (@owlstronaut) * [`4f74601`](4f74601) [#126](#126) postinstall workflow updates (#126) (@owlstronaut) * [`3cbc2b2`](3cbc2b2) [#132](#132) bump @npmcli/template-oss from 4.26.0 to 4.27.1 (#132) (@dependabot[bot], @npm-cli-bot) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodejs 22.20.0 had a behavior change in trailing slashes for windows. This branches on the expected result. nodejs/node#59847