Skip to content
This repository was archived by the owner on Feb 25, 2022. It is now read-only.

update nx version to 12.4.0#76

Merged
jaysoo merged 1 commit into
nrwl:mainfrom
xiongemi:feature/update-nx-version-12-4-0
Jun 28, 2021
Merged

update nx version to 12.4.0#76
jaysoo merged 1 commit into
nrwl:mainfrom
xiongemi:feature/update-nx-version-12-4-0

Conversation

@xiongemi

@xiongemi xiongemi commented Jun 18, 2021

Copy link
Copy Markdown
Contributor
  • update nx version of the workspace to 12.4.0

@xiongemi xiongemi force-pushed the feature/update-nx-version-12-4-0 branch from e94c34a to c15b859 Compare June 18, 2021 05:19
@xiongemi

xiongemi commented Jun 18, 2021

Copy link
Copy Markdown
Contributor Author

failed due to react native and jest 27 issue: callstack/react-native-testing-library#743.
@nrwl/jest will migrate jest to 27.0.3. however, it has issues with react native testing. it has a workaround for yarn, but not for npm. so i think i need to wait for a release with react/react-native#30637 merged.

@xiongemi xiongemi marked this pull request as draft June 18, 2021 19:16
@xiongemi

xiongemi commented Jun 18, 2021

Copy link
Copy Markdown
Contributor Author

upgrade react naive version to 0.65. however, the unit test does not run because @testing-library/react-native does not support react native version 0.65. got a timeout error when i try to run unit tests: thrown: "Exceeded timeout of 5000 ms for a hook. on line import { render } from '@testing-library/react-native';.
convert this to a draft or.
TODO:

  • add migration script to add testEnvironment: 'node' to all jest.config for react native app and lib
  • add migration script to add react-native-codegen to dev dependency

@xiongemi xiongemi force-pushed the feature/update-nx-version-12-4-0 branch 4 times, most recently from 7cb60df to 8ba1f98 Compare June 22, 2021 23:14
@xiongemi xiongemi marked this pull request as ready for review June 23, 2021 00:27
Comment thread jest.config.js Outdated
- remove @nrwl/react being added to workspace since react native project does not have directly reference to @nrwl/react
- update nx version to 12.4.0
- remove jest.useFakeTimers in test-setup
- add migration scripts
@xiongemi xiongemi force-pushed the feature/update-nx-version-12-4-0 branch from 8ba1f98 to 9458b88 Compare June 24, 2021 21:15
@xiongemi xiongemi requested a review from jaysoo June 25, 2021 14:25
@xiongemi xiongemi mentioned this pull request Jun 25, 2021
@jaysoo jaysoo merged commit 64188a2 into nrwl:main Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants