Fix a retain cycle of STHTTPRequest objects in STTwitterOAuth.#148
Merged
Conversation
Under ARC (and not under MRR), variables declared __block are retained when captured in a copied block. The solution is to another __block __weak declared variable and use that within the blocks copied by the STHTTPRequest. This issue is particularly bad if you're posting images, as I was, because the image data is retained by the STHTTPRequest. So every image post you leak the whole image data.
nst
added a commit
that referenced
this pull request
Dec 13, 2014
Fix a retain cycle of STHTTPRequest objects in STTwitterOAuth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under ARC (and not under MRR), variables declared __block are retained
when captured in a copied block. The solution is to another __block
__weak declared variable and use that within the blocks copied by the
STHTTPRequest.
This issue is particularly bad if you're posting images, as I was,
because the image data is retained by the STHTTPRequest. So every
image post you leak the whole image data.