forked from pingdotgg/t3code
-
Notifications
You must be signed in to change notification settings - Fork 0
fix(server): resolve Claude SDK executable path on Windows npm installs #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
7dedcc3
fix(server): resolve Claude SDK executable path on Windows npm installs
nsxdavid ef7f1d2
fix(server): address review feedback on Claude executable resolution
nsxdavid 1224877
Merge branch 'main' into fix/windows-claude-sdk-executable-path
nsxdavid b982337
[codex] Fix onboarding connection status (#4001)
juliusmarminge 5e8b2c8
Isolate native diff highlight grammar state (#4029)
juliusmarminge 0418301
Fix macOS fullscreen titlebar spacing (#4019)
D3OXY d114e27
Prevent duplicate project workspace roots (#3829)
juliusmarminge 54f167e
Normalize over-indented markdown list items (#4020)
juliusmarminge bde0a4c
Resolve localhost preview URLs for remote environments (#4011)
juliusmarminge 2a33a18
fix(mobile): Send composer images in upload wire format (#4035)
juliusmarminge 5d68fca
Fix iOS terminal Enter input encoding (#4043)
juliusmarminge fdca154
Add native mobile share target support (#4021)
juliusmarminge 8a02c71
[codex] Expand real-route app store screenshot harness (#4014)
juliusmarminge eb733c1
fix(server): use CLAUDE_CONFIG_DIR instead of HOME for Claude instanc…
dmstoykov c14a5ca
Fix dropped events during initial thread snapshot (#4079)
D3OXY 1f27973
feat: show nightly update changelog tooltip (#3832)
HugoVizcainoSantana 58302b2
fix(git): treat selected commit paths literally (#3998)
EricTsai83 8b54698
fix(server): stabilize non-repository Git diagnostics (#4077)
EricTsai83 6e9987c
Refresh app icons across release variants (#4080)
juliusmarminge 0748134
Update marketing GitHub star count (#4088)
AmoonPod 4804a98
fix(marketing): correct Cursor icon color (#4090)
AmoonPod c49d424
Normalize protocol-relative remote host input as https (#3971)
kridaydave 7f1cb61
fix(cursor): default binary path to cursor-agent (avoid path conflict…
BunnyGamezsc d4110b3
Merge branch 'main' into fix/windows-claude-sdk-executable-path
nsxdavid f9a4f59
Fix documented task-runner commands (bun run -> vp) (#3965)
kridaydave a7f6d97
Allow preview panel to grow on wide displays (#4044)
olivoil ca13561
Merge branch 'main' into fix/windows-claude-sdk-executable-path
juliusmarminge e057e2e
fix: prevent initial right-click from selecting a context menu item (…
Fazalkadivar21 7dc7512
Fix duplicate keybinding rule when replacing with an existing rule (#…
kridaydave ed81c15
fix(server): image upload crashed dispatchCommand with a stack overfl…
t3dotgg b49a2e6
Remove unused code parameter from describePreviewError (#3970)
kridaydave bcd640b
[codex] prevent ACP assistant ID collisions after restarts (#3932)
maxwellyoung 7b8d126
fix(web): inset Windows desktop scrollbars from resize edge (#4097)
nateEc 6a17629
[codex] fix mobile composer Enter behavior (#3930)
maxwellyoung cf58cad
feat(server): include runtime model and effort in Codex developer ins…
t3dotgg 143b9c9
fix(ux): spamming cmd + , no longer stack opening settings (#2757)
jamesx0416 220017b
Merge branch 'main' into fix/windows-claude-sdk-executable-path
nsxdavid 1047dac
fix(terminal): strip AppImage runtime env from spawned terminals (#3108)
leorivastech 4e3f2f0
fix(server): thread cwd through Claude capability probe (#2048) (#2124)
mvanhorn b655a9f
[codex] fix: guard invalid web timestamps (#3515)
StiensWout 43e2aea
[codex] fix: tolerate invalid latest user message timestamps (#3521)
StiensWout 73bf127
[codex] Fix provider update checks restore defaults (#3531)
StiensWout 31ca9e5
fix(server): skip undecodable provider runtime rows when listing sess…
t3dotgg 24f9c2a
Share MCP OAuth locks across Codex shadow homes (#4104)
juliusmarminge 8b33799
Preserve T3 Code identity in macOS development launcher (#4102)
juliusmarminge 5ca3266
fix(web): increase contrast of question option descriptions (#3867)
xxashxx-svg 1bd2fa2
feat: draft hero landing on the index route (#4055)
yordis 4cfec8c
feat: file explorer mention actions and zoom-aware context menus (#4054)
yordis 2318e00
fix(web): avoid duplicate mention text on paste
juliusmarminge 03e20c8
fix(mobile): restore iOS home screen branding (#4025)
PixPMusic 765e1b5
perf(client): defer active thread cache writes (#4006)
Chrrxs 38e0bb0
Default diffs to working changes (#3974)
jakeleventhal e350c0a
Add Grok to marketing site provider list (#3484)
Aditya190803 31caa56
Fix reopening existing Diff tab (#3973)
jakeleventhal d8b12ae
Fix sending messages during active turns (#3919)
jakeleventhal d0b9f8d
[codex] Route OpenCode missing-session errors through Effect (#3608)
StiensWout c0e161a
[fix/feat:ui] Show default option badge (#3232)
sandersonstabo e63403f
[fix/feat:ui] Preserve open-in editor brand colors (#3225)
sandersonstabo b859a57
fix(web): handle macOS Home and End in composer (#2508)
GuilhermeVieiraDev 0506508
Allow failed remote environments to be removed (#4084)
zepi2509 da3c203
[codex] canonicalize client timestamps (#4112)
maxwellyoung 5c66110
[fix/feat:ui] Make selected menu checks blue (#3234)
sandersonstabo bf76535
fix(desktop): Validate WSL node version against engine range after pr…
UtkarshUsername ebe8afb
Refresh splash screen and favicon branding (#4120)
juliusmarminge 1735e27
Add terminal selection copy action (#2904)
tarik02 b213574
Merge branch 'main' into fix/windows-claude-sdk-executable-path
nsxdavid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,134 @@ | ||
| name: Mobile Showcase Screenshots | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| platform: | ||
| description: Device platforms to capture | ||
| required: true | ||
| default: all | ||
| type: choice | ||
| options: | ||
| - all | ||
| - ios | ||
| - android | ||
| appearance: | ||
| description: System appearances to capture | ||
| required: true | ||
| default: both | ||
| type: choice | ||
| options: | ||
| - both | ||
| - dark | ||
| - light | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| env: | ||
| NODE_OPTIONS: --max-old-space-size=8192 | ||
|
|
||
| jobs: | ||
| ios: | ||
| name: iPhone 6.9, iPhone 6.5, and iPad 13 | ||
| if: inputs.platform == 'all' || inputs.platform == 'ios' | ||
| runs-on: blacksmith-12vcpu-macos-26 | ||
| timeout-minutes: 60 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Setup Vite+ | ||
| uses: voidzero-dev/setup-vp@v1 | ||
| with: | ||
| node-version-file: package.json | ||
| cache: true | ||
| run-install: true | ||
|
|
||
| - name: Expose pnpm | ||
| run: | | ||
| pnpm_version="$(node --print "require('./package.json').packageManager.split('@').pop()")" | ||
| vp_pnpm_bin="$HOME/.vite-plus/package_manager/pnpm/$pnpm_version/pnpm/bin" | ||
| echo "$vp_pnpm_bin" >> "$GITHUB_PATH" | ||
| "$vp_pnpm_bin/pnpm" --version | ||
|
|
||
| - name: Capture iOS showcase | ||
| run: pnpm screenshots:mobile --platform ios --appearance "${{ inputs.appearance }}" | ||
|
|
||
| - name: Validate App Store Connect assets | ||
| run: pnpm screenshots:mobile --platform ios --appearance "${{ inputs.appearance }}" --validate-only | ||
|
|
||
| - name: Upload iOS screenshots | ||
| if: always() | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: app-store-connect-screenshots | ||
| path: artifacts/app-store/screenshots/apple/ | ||
| if-no-files-found: warn | ||
| retention-days: 14 | ||
|
|
||
| android: | ||
| name: Android phone, 7-inch tablet, and 10-inch tablet | ||
| if: inputs.platform == 'all' || inputs.platform == 'android' | ||
| runs-on: blacksmith-16vcpu-ubuntu-2404 | ||
| timeout-minutes: 60 | ||
| env: | ||
| T3_SHOWCASE_ANDROID_ABI: x86_64 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v6 | ||
|
|
||
| - name: Setup Vite+ | ||
| uses: voidzero-dev/setup-vp@v1 | ||
| with: | ||
| node-version-file: package.json | ||
| cache: true | ||
| run-install: true | ||
|
|
||
| - name: Expose pnpm | ||
| run: | | ||
| pnpm_version="$(node --print "require('./package.json').packageManager.split('@').pop()")" | ||
| vp_pnpm_bin="$HOME/.vite-plus/package_manager/pnpm/$pnpm_version/pnpm/bin" | ||
| echo "$vp_pnpm_bin" >> "$GITHUB_PATH" | ||
| "$vp_pnpm_bin/pnpm" --version | ||
|
|
||
| - name: Setup Java | ||
| uses: actions/setup-java@v5 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 17 | ||
|
|
||
| - name: Setup Gradle cache | ||
| uses: gradle/actions/setup-gradle@v5 | ||
|
|
||
| - name: Enable KVM | ||
| run: | | ||
| echo 'KERNEL=="kvm", GROUP="kvm", MODE="0666", OPTIONS="static_node=kvm"' \ | ||
| | sudo tee /etc/udev/rules.d/99-kvm4all.rules | ||
| sudo udevadm control --reload-rules | ||
| sudo udevadm trigger --name-match=kvm | ||
|
|
||
| - name: Capture Android showcase | ||
| uses: reactivecircus/android-emulator-runner@v2 | ||
| with: | ||
| api-level: 36 | ||
| target: google_apis | ||
| arch: x86_64 | ||
| profile: pixel_7_pro | ||
| avd-name: Pixel_10_Pro | ||
| cores: 8 | ||
| ram-size: 4096M | ||
| disable-animations: false | ||
| script: pnpm screenshots:mobile --platform android --appearance "${{ inputs.appearance }}" | ||
|
|
||
| - name: Validate Google Play assets | ||
| run: pnpm screenshots:mobile --platform android --appearance "${{ inputs.appearance }}" --validate-only | ||
|
|
||
| - name: Upload Android screenshots | ||
| if: always() | ||
| uses: actions/upload-artifact@v7 | ||
| with: | ||
| name: google-play-screenshots | ||
| path: artifacts/app-store/screenshots/google-play/ | ||
| if-no-files-found: warn | ||
| retention-days: 14 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Disable persisted checkout credentials in both jobs.
Neither job requires Git authentication after checkout, but both retain the workflow token while dependency installation and capture tooling execute.
.github/workflows/mobile-showcase-screenshots.yml#L38-L39: setpersist-credentials: falsefor the iOS checkout..github/workflows/mobile-showcase-screenshots.yml#L78-L79: setpersist-credentials: falsefor the Android checkout.🧰 Tools
🪛 zizmor (1.26.1)
[warning] 38-39: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
📍 Affects 1 file
.github/workflows/mobile-showcase-screenshots.yml#L38-L39(this comment).github/workflows/mobile-showcase-screenshots.yml#L78-L79🤖 Prompt for AI Agents
Source: Linters/SAST tools