Skip to content

fix: fix for invalid container id #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mayankpande88 merged 2 commits into from
Apr 8, 2025
Merged

fix: fix for invalid container id #124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
320d445
fix: fix for invalid container id
mayankpande88 Apr 7, 2025
0d80ec8
fix: fix for container id parsing
mayankpande88 Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions containers/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package containers

import (
"errors"
"io"
"log"
"net/http"
Expand Down Expand Up @@ -169,11 +170,11 @@ func NewContainer(id ContainerID, cg *cgroup.Cgroup, md *ContainerMetadata, pid
return nil, err
}
defer netNs.Close()
// /k8s/%s/%s/%s split
// /k8s/ -> namespace
// %s -> pod name

split := strings.Split(string(id), "/")
if len(split) < 4 {
klog.Errorf("unexpected container id %s", id)
Comment thread
mayankpande88 marked this conversation as resolved.
return nil, errors.New("unexpected container id")
}
namespace := split[2]
podName := split[3]
src_workload := registry.ip_resolver.ResolvePodOwner(podName, namespace)
Expand Down