⚡ Bolt: Optimize decodeAddr in proc/net to zero allocations#194
Conversation
Replaced make([]byte) with stack-allocated arrays for IP and port buffers. Used hex.Decode directly into stack buffers. This eliminates heap allocations in the hot path of parsing /proc/net/tcp. Benchmarks: IPv4: 88ns -> 38ns (-57%) IPv6: 160ns -> 67ns (-58%) Allocs: 1 -> 0 (-100%) Co-authored-by: blue4209211 <3078106+blue4209211@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
mayankpande88
left a comment
mayankpande88
left a comment
There was a problem hiding this comment.
Clean optimization — stack-allocated buffers, separate IPv4/IPv6 paths, removes net import dependency. Correct.
One thing to fix before merging: remove the .jules/bolt.md file from the PR. It's bot metadata that shouldn't be committed to the repo.
mayankpande88
deleted the
bolt/optimize-proc-decodeaddr-412884711624083843
branch
2 participants
make([]byte, ...)) with stack-allocated arrays and manual hex parsing indecodeAddr.decodeAddris called for every socket in/proc/net/tcp, causing significant allocations (1 alloc/op).proc/bench_test.go).PR created automatically by Jules for task 412884711624083843 started by @blue4209211