fix: add missing patternsPerLevelLimit param to logparser.NewParser c…

[mayankpande88]

…alls

[gemini-code-assist]

Summary of Changes

Hello @mayankpande88, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug where the logparser.NewParser constructor was being invoked without a crucial patternsPerLevelLimit parameter. The changes ensure that every instantiation of the log parser now correctly includes this parameter, enhancing the robustness and proper configuration of log processing, particularly within container environments.

Highlights

• Parameter Addition: Added the patternsPerLevelLimit parameter to all logparser.NewParser constructor calls across the codebase.
• Log Parser Initialization: Ensured that the log parser is correctly initialized with the patternsPerLevelLimit flag, fixing a previous omission.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• common/log_parser_test.go
  • Updated the logparser.NewParser call in TestLogParser to include the new patternsPerLevelLimit argument with a default value of 256.
• containers/container.go
  • Modified three separate calls to logparser.NewParser within the runLogParser function to pass the *flags.LogPatternsPerContainer value as the patternsPerLevelLimit argument.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds the missing patternsPerLevelLimit parameter to all calls to logparser.NewParser. However, a security audit identified two high-severity vulnerabilities: a hardcoded AWS access key in a test file, posing a significant risk of credential leakage, and a path traversal vulnerability in the log tailing feature, which could allow an attacker to read arbitrary files from the host system. Immediate remediation for these findings is recommended. Additionally, for code clarity, consider replacing a magic number with a named constant in a test file.