fix: suppress noisy uprobe symbol-not-found errors#242
Merged
Conversation
… binaries Binaries like calico-node match the nodejs detection regex but lack uv__io_poll. Similarly, some libpthread.so builds lack pthread_cond_timedwait. These are expected failures, not actionable errors — suppress them like other benign attachment failures.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the error suppression logic in ebpftracer/nodejs.go and ebpftracer/python.go to include the "not found" suffix. Feedback indicates that this suffix is too generic and could inadvertently suppress unrelated errors, such as namespace PID lookup failures. It is recommended to use a more specific check for symbol lookup failures and to centralize this duplicated logic within the Tracer struct to improve maintainability.
blue4209211
previously approved these changes
Apr 16, 2026
Generic "not found" suffix could mask unrelated errors. Match the specific error format from elf.go GetSymbol instead.
RamanKharchee
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calico-nodematch the nodejs detection regex but lackuv__io_poll, and somelibpthread.sobuilds lackpthread_cond_timedwait— these are expected failures, not actionable errors"not found"to the existing suppressed error suffix list in bothnodejs.goandpython.goTest plan
failed to attach nodejs uprobes: symbol uv__io_poll not founderrors for calico-nodefailed to attach python uprobes: symbol pthread_cond_timedwait not founderrors for stripped libpthreadnodejs uprobes attached/python uprobes attachedinfo logs)