ci: migrate image publish from ECR to GHCR (single-branch release)#245
Merged
Conversation
… policy Drops dev-ci.yaml (main->dev ECR) and prod-ci.yaml (prod branch->prod ECR). Release workflow now triggers on v* tags pushed to main and fails fast if the tag isn't reachable from main. Replaces deprecated upload-release-asset + github-script with softprops/action-gh-release.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
RamanKharchee
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dev-ci.yamlandprod-ci.yaml— both pushed to ECR (864186153326...frommain,740395098545...fromprod). Theprodbranch becomes unused under the single-branch policy.release.ymlto publish to GHCR (ghcr.io/nudgebee/node-agent) onv*tags pushed tomain. Agit merge-base --is-ancestorcheck fails the build if the tag isn't reachable frommain, enforcing the single-branch release policy.actions/upload-release-asset@v1+github-scriptrelease update withsoftprops/action-gh-release@v2, which creates the release, attaches both arch binaries, and marks it latest.{{version}},{{major}}.{{minor}},{{major}}(dropped branch/PR tag variants since the workflow only fires on tags now).Release flow going forward
mainvia PR.mainwithvX.Y.Zand push the tag.Test plan
main.v0.0.0-test1) onmainand confirm the workflow builds, pushes toghcr.io/nudgebee/node-agent, and attaches both binaries to the release.864186153326...,740395098545...) to switch toghcr.io/nudgebee/node-agent.