Feat sort assets in verified tab by uploaded at#3158
Merged
sultanmyrza-numbersprotocol merged 6 commits intov240104-capture-cam-ionic-launchfrom Jan 11, 2024
Conversation
storeIndexedProof is called from storeRemoteCapture. storeRemoteCapture most of the time is called when user restore (during app start) or reload (triggers pull to refresh)
shc261392
reviewed
Dec 26, 2023
| : this.timestamp * MILLISECONDS_PER_SECOND; | ||
|
|
||
| try { | ||
| const serverTimestampInMilliseconds = Date.parse(this.uploadedAt ?? ''); |
Contributor
There was a problem hiding this comment.
The try-catch clause seems unnecessary here. Date.parse returns NaN for empty string or string that cannot be parsed into timestamp.
Contributor
Author
There was a problem hiding this comment.
@shc261392, you are right I tested with empty string, invalid date string it return NaN. Here is the commit refactor(proof.ts): remove unused try catch block
sultanmyrza
changed the base branch from
v231207-capture-cam-ionic
to
v240104-capture-cam-ionic-launch
shc261392
approved these changes
Jan 11, 2024
sultanmyrza-numbersprotocol
merged commit d09dc29
into
v240104-capture-cam-ionic-launch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3138
┆Issue is synchronized with this Asana task by Unito