Skip to content

Improve macOS version check in order to use Accelerate NEWLAPACK #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgommers merged 1 commit into from
Oct 31, 2023
Merged

Improve macOS version check in order to use Accelerate NEWLAPACK #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion mesonbuild/dependencies/blas_lapack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import functools
import os
from pathlib import Path
import platform
import re
import subprocess
import sys
Expand Down Expand Up @@ -525,9 +526,12 @@ def __init__(self, name: str, environment: 'Environment', kwargs: T.Dict[str, T.
self.detect(kwargs)

def check_macOS_recent_enough(self) -> bool:
# We need the SDK to be >=13.3 (meaning at least XCode 14.3)
cmd = ['xcrun', '-sdk', 'macosx', '--show-sdk-version']
sdk_version = subprocess.run(cmd, capture_output=True, check=True, text=True).stdout.strip()
return sdk_version >= '13.3'
macos_version = platform.mac_ver()[0]
deploy_target = os.environ.get('MACOSX_DEPLOYMENT_TARGET', macos_version)
return sdk_version >= '13.3' and deploy_target >= '13.3'

def detect(self, kwargs: T.Dict[str, T.Any]) -> None:
from .framework import ExtraFrameworkDependency
Expand Down