Skip to content

BUG: fix macOS version checks so things work in very old versions #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgommers merged 1 commit into from
Dec 22, 2023
Merged

BUG: fix macOS version checks so things work in very old versions #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions mesonbuild/dependencies/blas_lapack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,12 +742,15 @@ def __init__(self, name: str, environment: 'Environment', kwargs: T.Dict[str, T.
self.detect(kwargs)

def check_macOS_recent_enough(self) -> bool:
# We need the SDK to be >=13.3 (meaning at least XCode 14.3)
cmd = ['xcrun', '-sdk', 'macosx', '--show-sdk-version']
sdk_version = subprocess.run(cmd, capture_output=True, check=True, text=True).stdout.strip()
macos_version = platform.mac_ver()[0]
deploy_target = os.environ.get('MACOSX_DEPLOYMENT_TARGET', macos_version)
return sdk_version >= '13.3' and deploy_target >= '13.3'
if not mesonlib.version_compare(deploy_target, '>=13.3'):
return False

# We also need the SDK to be >=13.3 (meaning at least XCode 14.3)
cmd = ['xcrun', '-sdk', 'macosx', '--show-sdk-version']
sdk_version = subprocess.run(cmd, capture_output=True, check=True, text=True).stdout.strip()
return mesonlib.version_compare(sdk_version, '>=13.3')

def detect(self, kwargs: T.Dict[str, T.Any]) -> None:
from .framework import ExtraFrameworkDependency
Expand Down