TYP: Fix type annotations for np.ma.nomask and np.ma.MaskType#28831
Merged
Conversation
MarcoGorelli
force-pushed
the
fix-ma-nomask-masktype
branch
2 times, most recently
from
f5529e1 to
2ea4c4c
Compare
MarcoGorelli
force-pushed
the
fix-ma-nomask-masktype
branch
from
2ea4c4c to
f69a24c
Compare
jorenham
reviewed
Apr 26, 2025
52 tasks
jorenham
approved these changes
Apr 26, 2025
Member
Author
|
thanks for your review! |
Member
|
Thanks Marco! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure that the current type hints are correct for these, as
np.ma.nomaskreturns a NumPy boolean, not a stdlib one