PRs fail in Update Preview link comment

[mikkelbu]

It seem like all PRs fail in the build step Update Preview link comment below Netlify Preview (PR only). The error is

Error: The template is not valid. .github/workflows/build-process.yml (Line: 124, Col: 20): Error reading JToken from JsonReader. Path '', line 0, position 0.

From the error message it seems like the netlify step did not produce any output, so that steps.netlify.outputs.NETLIFY_OUTPUT is the empty string.

E.g. in
https://github.com/nunit/docs/actions/runs/15324470078/job/43115457653?pr=1044

[SeanKilleen]

Duplicate of #988 I believe.

[SeanKilleen]

Sorry, I mean a duplicate of #983.

[mikkelbu]

@SeanKilleen Are you sure? #983 is about a failure in "Start deployment (PR only)". This step was successful in https://github.com/nunit/docs/actions/runs/15324470078/job/43115457653?pr=1044, but the later step "Update Preview link comment" failed

[SeanKilleen]

@mikkelbu hmm, definitely not sure. Could be something different.

Right now what I'm taking away from this is that the netlify preview was a nice idea but it's hacked together with duct tape and causing more problems then it solves

I'll likely be removing it and seeing what else I can do to get to a similar outcome.

[OsirisTerje]

It was nice when it worked though :-)
But better to remove it if it can't be fixed, and then as you say, see if we/you can find something better ;-)

[SeanKilleen]

As of now, the Netlify preview has been removed.

To preview any PR, you can open the PR in a Codespace and run the serve shortcut. This can be done in local VSCode or in GitHub Codespaces online. 👍

I'll look for another method for achieving this.