[Karan Dev Sapra] Duke Increments by aang114 · Pull Request #356 · nus-cs2103-AY1920S1/duke

aang114 · 2019-09-02T16:41:06Z

No description provided.

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on `gradle` to be executable (nus-cs2103-AY1920S1#9)

Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.

Add configuration for console applications

… does not follow the dd/MM/yyyy... format)

… & Wrapped Single statement conditionals & Single statement classes with curly brackets)

merging gradle into master

tcgj

Looks good!

tcgj · 2019-09-03T14:56:14Z

src/main/java/ListCommand.java

+    @Override
+    public void execute(TaskList taskList, Ui ui, Storage storage) throws IOException {
+        ui.list();
+        taskList.list();


Perhaps you might want to make the two methods here somewhat clearer in terms of naming? Both ui.list() and taskList.list() seem to mean the same thing even though they most likely do very different things.

tcgj · 2019-09-03T15:00:32Z

src/main/java/Parser.java

+            return new ListCommand();
        case "bye":
-            return Bot.TaskType.BYE;
+            return new ExitCommand();


Would it be better if you kept these two commands together with the rest of the switch statement so that it remains as a block? If you have no spaces, split actually returns you an array containing just the command itself, so word[0] would still correspond to "list" and "bye" in those cases.

Yes, I do agree with Terence

tcgj · 2019-09-03T15:03:23Z

src/main/java/Parser.java

+
+    }
+
+    public static Task parsesAdd (String command, TaskType taskType) throws DukeException {


Perhaps it may be better to rename your function to an imperative, maybe parseAdd? This is so that the function adheres to coding standards, and states "what it will do" rather than "what it does".

tcgj · 2019-09-03T15:05:40Z

src/main/java/Parser.java

+
+        String description;
+
+        switch (taskType) {


Hmm, I wonder if it's very efficient if you have another switch statement here considering you already individually parsed the type of task to add inside of your parse function. Not sure if it would be better to have three different functions here instead. Might be debatable!

tcgj · 2019-09-03T15:08:11Z

src/main/java/Storage.java


-    public void retrieve () throws FileNotFoundException {
-        File f = new File(Storage.DUKE_TXT_PATH); // create a File for the given file path
+    public ArrayList<Task> retrieve () throws FileNotFoundException {


Would it be better if you checked if the file existed, then returned an empty list, rather than throw a FileNotFoundException if it didn't already exist?

honhaochen

Command Class:

Under execute method, i think it's very expensive to store the entire list again and again for every command. Wouldn't it already served the purpose if you just save it in during your ExitCommand?

Overall:

Some files are missing JavaDocs (FindCommand)
Great coding conventions
Great implementations! However, some recommendations can be found in the code specifically.

honhaochen · 2019-09-03T14:09:29Z

src/main/java/DateClass.java

+
+        try {
+            date = format.parse(string);
+        } catch (ParseException e) {


Would it be better to handle the exception instead of doing nothing?
Let's say you can throw ParseException to Duke class and let it handle the output/ message.

honhaochen · 2019-09-03T14:23:31Z

src/main/java/Duke.java

+        try {
+            tasks = new TaskList(storage.retrieve());
+        } catch (FileNotFoundException e) {
+


Would it be better to inform the user about the exception?
For me particularly I would inform that "file isn't found, a new file will be created instead"

honhaochen · 2019-09-03T14:44:23Z

src/main/java/TaskList.java

+        return task;
+    }
+
+    public Task[] find(String text) {


Would it be easier to return ArrayList?

…t all the text fits as the TaskList shrinks or grows

…ld at various points in the code.

…ality (where necessary)

Critically examined the code and refactored it to improve the code qu…

Added assert feature to document important assumptions that should ho…

j-lum and others added 30 commits August 6, 2019 15:25

Add support for Gradle workflow

65f72a8

Add sample checkstyle configuration

0112efe

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on gradle to be executable

cfd6da7

Merge pull request nus-cs2103-AY1920S1#12 from j-lum/gradle+x

6e6ace1

Change file mode on `gradle` to be executable (nus-cs2103-AY1920S1#9)

Add configuration for console applications

a3ca5a4

Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.

Merge pull request nus-cs2103-AY1920S1#13 from j-lum/javaexec

7b60e81

Add configuration for console applications

Level-1

6dfbb70

Level-1

87fb84e

Level-2

24796d0

Level-2

f302e6b

Level-3

e5ec66b

Level-4

76204fe

Level-5

9a81e57

Level-6

4ff446c

Level-7

a504967

Level-8

0ec0fe4

Merge branch 'branch-Level-8'

1a541a9

Level-7 (removing a few print lines that I had put for debugging)

e26dc70

Merge branch 'master' into branch-Level-7

313de67

Level-8 (won't display error message if the date inputted by the uses…

9559d8a

… does not follow the dd/MM/yyyy... format)

Merge branch 'branch-Level-8'

35acea9

Making it more OOP

e8daed2

Merge branch 'branch-Level-7'

1c21635

A-MoreOOP

8219d3d

A-JUnit

808d2dd

Level-9 (Now Able to Find Tasks!)

e5b08a3

A-JavaDoc (Added Java Doc for every class & every method)

e56bf4d

A-CodingStandard (Changed the Access Modifier of some class variables…

dfe5277

… & Wrapped Single statement conditionals & Single statement classes with curly brackets)

Merge branch 'branch-A-CodingStandard' into master

16f1bda

Merge branch 'branch-Level-9' into master

5304e70

Karan Dev Sapra added 2 commits September 3, 2019 17:30

Merge branch 'gradle'

d9893cc

merging gradle into master

Fixed a bug (there was a merge conflict so it wasn't compiling)

d708610

tcgj reviewed Sep 3, 2019

View reviewed changes

honhaochen reviewed Sep 3, 2019

View reviewed changes

Karan Dev Sapra added 5 commits September 4, 2019 15:38

Created my first GUI application! (a window that says Hello World)

0f9f7bd

Created the GUI for Duke (but without any functionality)

2e58d6b

Iteration 1 – Echoing the User

59acd1a

Iteration 2 – Adding Dialog Boxes

5131533

Duke GUI now responds to user input!

85bffc6

nus-se-pr-bot added tutorial.CS2103T-T11 tutor.jeffgan96 team.4 labels Sep 6, 2019

Karan Dev Sapra and others added 14 commits September 30, 2019 17:01

Making JUnit work with Gradle (and adding more unit testing functions)

07298f9

Made the DialogBox have resizable width (through SceneBuilder) so tha…

8f60f0f

…t all the text fits as the TaskList shrinks or grows

Merge branch 'branch-Level-10'

acb5af9

Added assert feature to document important assumptions that should ho…

8a19a8b

…ld at various points in the code.

Critically examined the code and refactored it to improve the code qu…

e461b9a

…ality (where necessary)

Merge pull request #5 from eizon05/branch-A-CodeQuality

8d53e2c

Critically examined the code and refactored it to improve the code qu…

Merge branch 'master' into branch-A-Assertions

af61ae9

Merge pull request #6 from eizon05/branch-A-Assertions

b54fc5f

Added assert feature to document important assumptions that should ho…

Add Ui.png

015f926

Update README.md

022e6c7

Update README.md

1360dee

Update README.md

540fb54

Update README.md

a966f0a

Update README.md

63aebb5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Karan Dev Sapra] Duke Increments#356

[Karan Dev Sapra] Duke Increments#356
aang114 wants to merge 51 commits intonus-cs2103-AY1920S1:masterfrom
aang114:master

aang114 commented Sep 2, 2019

Uh oh!

tcgj left a comment

Uh oh!

tcgj Sep 3, 2019

Uh oh!

tcgj Sep 3, 2019

Uh oh!

honhaochen Sep 3, 2019

Uh oh!

tcgj Sep 3, 2019

Uh oh!

tcgj Sep 3, 2019

Uh oh!

tcgj Sep 3, 2019

Uh oh!

honhaochen left a comment

Uh oh!

honhaochen Sep 3, 2019

Uh oh!

honhaochen Sep 3, 2019

Uh oh!

honhaochen Sep 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants


		}

		public static Task parsesAdd (String command, TaskType taskType) throws DukeException {

Conversation

aang114 commented Sep 2, 2019

Uh oh!

tcgj left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

honhaochen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants