[Chen Jiehan] Duke Increments by ChenJiehan318 · Pull Request #362 · nus-cs2103-AY1920S1/duke

ChenJiehan318 · 2019-09-03T15:32:21Z

No description provided.

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on `gradle` to be executable (#9)

1nefootstep

Hello, I like the splitting of commands into different classes, would definitely help when expanding on the list of commands to use. One thing I have difficulties understanding is the isExit method for all commands. Could the same be accomplished by return false/true without the isExit boolean? Also, I noticed that the ByeCommand isExit method seems to return false, which would let the loop on Duke continue. Is that intended or did I misinterpret the code?

Nice job on the date formatting too!

OneArmyj

Overall, nice work, code is easy to read and follow through. OOP was done well. However, just take note of package naming, and complete your JavaDocs.

OneArmyj · 2019-09-05T08:35:26Z

src/main/java/Command/AddCommand.java

+    }
+
+    /**
+     * execute the command of adding task


Incomplete JavaDocs, should give clearer description.

OneArmyj · 2019-09-05T08:43:31Z

src/main/java/Command/AddCommand.java

@@ -0,0 +1,41 @@
+package Command;


Package naming should begin with small letter to avoid conflict with names of classes or interfaces.

OneArmyj · 2019-09-05T08:45:00Z

src/main/java/Duke.java

+        private Storage storage;
+        private TaskList tasks;
+        private Ui ui;
+


Fields pertaining to Duke such as Storage, TaskList and Ui should be declared outside the main method block.

I believe this is due to the incorrect indentation level

OneArmyj · 2019-09-05T08:45:53Z

src/main/java/Duke.java

+            }
+        }
+
+        public static void main(String[] args) {


File path should be one that is accessible with reference to duke as the root file, rather than your C: Drive

OneArmyj · 2019-09-05T08:46:32Z

src/main/java/Parser/Parser.java

+    public static Command parse(String fullCommand) {
+        int i = fullCommand.indexOf(' ');
+        String first = getFirstWord(fullCommand);
+        switch (first) {


switch case indentation is off. Case should be aligned with switch, according to Java Coding Standard documentation.

OneArmyj · 2019-09-05T09:07:57Z

src/main/java/TaskList/Task.java

+        String aa;
+        int time;
+
+        switch (Integer.parseInt(str[0])) {


Wrong indentation for case.

dcshzj

Mostly indentation level issues and certain design implementation can be made better. Thank you for your work!

dcshzj · 2019-09-08T03:23:45Z

src/main/java/Command/AddCommand.java

+    }
+
+    /**
+     *


Missing method description

dcshzj · 2019-09-08T03:24:26Z

src/main/java/Command/Command.java

+
+    public abstract void execute(TaskList t, Ui ui, Storage storage) throws IOException;
+
+    public abstract boolean isExit();


Ideally, the name of the method should not be the same as the variable name

dcshzj · 2019-09-08T03:25:09Z

src/main/java/Command/Command.java

+
+    public Command() {}
+
+    public abstract void execute(TaskList t, Ui ui, Storage storage) throws IOException;


One suggestion is to allow this method to be overloaded, since not every command will require all 3 parameters to be used.

dcshzj · 2019-09-08T03:25:54Z

src/main/java/Command/DeleteCommand.java

+
+public class DeleteCommand extends Command {
+
+    private int taskNo;


Variable naming could be clearer, something like taskNumber

dcshzj · 2019-09-08T03:27:13Z

src/main/java/Duke.java

@@ -1,10 +1,59 @@
+import Command.Command;


This file has incorrect indentation level, plus multiple lines of unnecessary newlines.

dcshzj · 2019-09-08T03:33:40Z

src/main/java/TaskList/Deadlines.java

+
+    @Override
+    public String toString() {
+


Extra newline

dcshzj · 2019-09-08T03:33:46Z

src/main/java/TaskList/Deadlines.java

+public class Deadlines extends Task {
+
+    public Deadlines(String description) {
+


Extra newline

dcshzj · 2019-09-08T03:35:34Z

src/main/java/Ui/Ui.java

+        showToUser(error);
+    }
+
+    public void showToUser (String... message) {


Extra space between showToUser and (

dcshzj · 2019-09-08T03:36:00Z

src/test/java/DeleteCommandTest.java

+
+public class DeleteCommandTest {
+    @Test
+    public void executeTest() throws IOException {


The method name should be clear on what this test case is about

dcshzj · 2019-09-08T03:36:40Z

src/test/java/TaskTest.java

+
+public class TaskTest {
+    @Test
+    public void getStatusNumberTest() {


Incorrect naming convention for test method name

git pull

A-Assertions

A-CodeQuality

C-FriendlierSyntax

j-lum and others added 30 commits August 6, 2019 15:25

Add support for Gradle workflow

65f72a8

Add sample checkstyle configuration

0112efe

Add toolVersion block in to Gradle code sample to prevent errors.

Change file mode on gradle to be executable

cfd6da7

Merge pull request nus-cs2103-AY1920S1#12 from j-lum/gradle+x

6e6ace1

Change file mode on `gradle` to be executable (#9)

Complete Level 1

edf8e35

Complete Level 2

ddaef0b

Complete Level 3

8249041

Complete Level 4

0600a98

Complete Level 5

4413d92

Complete Level 6

13b8591

Complete Level 7

769b127

Complete Level 8

a1fd1d8

Merge branch 'branch-Level-8'

4d80d71

A-MoreOOP

68d6643

A-Packages

62e7419

JUnit

86bfb0c

Fix some bugs

6881d44

Javadoc

ea0ad5e

branch-A-CodingStandard

92b4e16

branch-Level-9

dfded26

resolve merge conflicts

00bba16

Merge branch 'branch-Level-9'

876163f

Delete DeleteCommandTest.html

b11c1a7

Delete type-search-index.zip

247ea35

Delete type-search-index.js

e782c6e

Delete stylesheet.css

7912df8

Delete serialized-form.html

66cc53b

Delete search.js

4290a0d

Delete script.js

9008d34

Delete package-tree.html

558bd01

ChenJiehan318 added 9 commits September 4, 2019 11:45

Delete ui-icons_2e83ff_256x240.png

dc02c20

Delete ui-icons_454545_256x240.png

67ca51d

Delete ui-icons_888888_256x240.png

335be23

Delete jszip-utils-ie.js

81d6360

Delete jszip-utils.js

ea0f657

Delete jszip-utils-ie.min.js

072bb1f

Delete jszip-utils.min.js

f98eb10

Delete jszip.js

81112fc

Delete jszip.min.js

04d981d

1nefootstep reviewed Sep 4, 2019

View reviewed changes

OneArmyj reviewed Sep 5, 2019

View reviewed changes

nus-se-pr-bot added tutor.LimZhengJieBenjamin tutorial.CS2103T-W13 team.4 labels Sep 6, 2019

dcshzj reviewed Sep 8, 2019

View reviewed changes

candacesg and others added 13 commits September 11, 2019 10:31

Add Gui

9d23054

Merge branch 'master' of https://github.com/ChenJiehan318/duke

b0a1494

git pull

update dialogbox

faeff8a

FXML

8396d41

A-Assertions

21eff20

Merge pull request #5 from ChenJiehan318/A-Assertions

b78a57b

A-Assertions

A-CodeQuality

288f22b

Merge pull request #6 from ChenJiehan318/A-CodeQuality

8983823

A-CodeQuality

C-FriendlierSyntax

9eec2a9

Merge pull request #7 from ChenJiehan318/C-FriendlierSyntax

b1f41cc

C-FriendlierSyntax

Add files via upload

6295dbc

Update README.md

e0035da

Set theme jekyll-theme-hacker

d9dd7e2

ChenJiehan318 changed the title ~~[Jiehan] Duke Increments~~ [Chen Jiehan] Duke Increments Sep 18, 2019

Add files via upload

e18cfca

+                  }
+                  /**
+                   *


		public abstract void execute(TaskList t, Ui ui, Storage storage) throws IOException;

		public abstract boolean isExit();


		public Command() {}

		public abstract void execute(TaskList t, Ui ui, Storage storage) throws IOException;


		public class DeleteCommand extends Command {

		private int taskNo;

		public class Deadlines extends Task {

		public Deadlines(String description) {

Conversation

ChenJiehan318 commented Sep 3, 2019

Uh oh!

1nefootstep left a comment

Choose a reason for hiding this comment

Uh oh!

OneArmyj left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dcshzj left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants