fix(completion): file completion for redirection target#16831
Merged
Conversation
blindFS
commented
Oct 8, 2025
blindFS
force-pushed
the
fix_redirection_completion
branch
from
65c6eff to
a9ddcf5
Compare
blindFS
force-pushed
the
fix_redirection_completion
branch
from
a9ddcf5 to
364c411
Compare
ysthakur
approved these changes
Oct 12, 2025
Member
ysthakur
left a comment
ysthakur
left a comment
There was a problem hiding this comment.
LGTM. Hopefully we don't run into any problems with the removal of the space splitting thing, but we can fix that later
| } | ||
|
|
||
| /// Helper function to extract file-path expression from redirection target | ||
| fn check_redirection_target(target: &RedirectionTarget, pos: usize) -> Option<&Expression> { |
Member
There was a problem hiding this comment.
Nitpick: I feel like extract would be better than check
Contributor
Author
There was a problem hiding this comment.
It was named extract_xxx initially LoL. I don't remember what made me change my mind.
Contributor
Author
There was a problem hiding this comment.
Probably because I later moved the position checking to this function.
ysthakur
added
A:completions
Member
|
For the release notes summary, something like "Added file completions for command redirections" should be enough |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16827
Release notes summary - What our users need to know
Added file completions for command redirections (
o>>,e>, ...)Tasks after submitting