fix: throw errors on overflow in duration integer multiplication#17063
Merged
Conversation
Contributor
|
Thanks |
fdncred
added
A:error-handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #17062.
This is a small change which adds checks for all potentially overflowing duration/integer operations, in addition to the sum check added in #16594. This doesn't include floating point operations, which might still overflow.
I also took the liberty to move the shared code into a function. It does mean that the span message will no longer have the operation name. If that's not acceptable, I can refactor it to use the operator name.
Release notes summary - What our users need to know