adjusted polars / slice command to return lazy output on lazy input#17067
Merged
Conversation
github-actions
Bot
added
A:plugin-polars
Contributor
Author
|
I tried to model the implementation off of "polars first" where it maps to different command_ functions based on the input type. I also added an example (I wanted to work off of a failing test). Let me know any missteps, new to the project, new-ish to Rust development. |
Contributor
|
Looks good, thanks! |
WindSoilder
added
notes:fixes
Contributor
|
Great work - Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes summary - What our users need to know
This PR fixes the "polars slice" command so that it will return a lazyframe output when given a lazyframe as input. Fixes #17065
Tasks after submitting