Skip to content

Provide CLI commands for querying node status and diagnostics#154

Merged
reinkrul merged 3 commits into
masterfrom
iss38-diagnostics-command
Mar 16, 2021
Merged

Provide CLI commands for querying node status and diagnostics#154
reinkrul merged 3 commits into
masterfrom
iss38-diagnostics-command

Conversation

@reinkrul

@reinkrul reinkrul commented Mar 16, 2021

Copy link
Copy Markdown
Member

Fixes #38

@codecov

codecov Bot commented Mar 16, 2021

Copy link
Copy Markdown

Codecov Report

Merging #154 (3213c48) into master (bb05d27) will decrease coverage by 0.01%.
The diff coverage is 85.18%.

Impacted Files Coverage Δ
core/status/cmd.go 75.00% <75.00%> (ø)
cmd/root.go 86.36% <100.00%> (+0.15%) ⬆️
core/status/engine.go 100.00% <100.00%> (ø)

@reinkrul
reinkrul marked this pull request as ready for review March 16, 2021 10:14

@woutslakhorst woutslakhorst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think returning diagnostics is enough. Status doesn't add anything,.

Comment thread core/status/cmd.go Outdated
@reinkrul
reinkrul requested a review from woutslakhorst March 16, 2021 11:25
@reinkrul
reinkrul merged commit e153cb6 into master Mar 16, 2021
@reinkrul
reinkrul deleted the iss38-diagnostics-command branch March 16, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'diagnostics' CLI command doesn't work

2 participants