Exclude retraction presentations from Discovery Service search#4193
Merged
Conversation
Retraction markers are stored on the timeline so Get() can replicate them, but must not surface from Search(). With an empty query, no credential join was applied, so retraction VPs (which have no credentials) were returned to API callers. Fixes #4192 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
reinkrul
requested review from
gerardsn,
stevenvegt and
woutslakhorst
as code owners
April 15, 2026 10:34
Contributor
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (1)
🛟 Help
|
reinkrul
added a commit
that referenced
this pull request
May 18, 2026
* Exclude retraction presentations from Discovery Service search (#4193) Retraction markers are stored on the timeline so Get() can replicate them, but must not surface from Search(). With an empty query, no credential join was applied, so retraction VPs (which have no credentials) were returned to API callers. Fixes #4192 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Make HTTPErrorHandler idempotent on committed responses (#4243) Echo's BodyDump middleware (used when http.log: metadata-and-body) calls c.Error(err) on its way out and still returns the err, so echo's server loop invokes HTTPErrorHandler a second time for the same request. The first invocation wrote the response correctly; the second logged the operation error a second time and warned "Unable to send error back to client, response already committed" — visible noise without a real problem. echo.DefaultHTTPErrorHandler short-circuits on Committed=true; ours did not. Mirror that behavior. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * Add v6.2.6 release notes Assisted by AI * Update release_notes.rst --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Steven van der Vegt <steven.vandervegt@s-curve.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RetractedVerifiablePresentation) were leaking throughGET /internal/discovery/v1/{serviceID}when the query was empty, becausesqlStore.searchonly joinsdiscovery_credentialfor non-empty queries.IsType(retractionPresentationType)skip in the result-assembly loop. SQL-level filtering would require a schema migration (no retraction column exists onpresentationRecord).Get()timeline still returns retraction markers (required for replication).Fixes #4192
Test plan
TestModule_Search/retracted_presentations_are_not_returnedfails before the fix and passes after.go test ./discovery/...passes.search()caller (subject-scoped query instore.go:585) is unaffected — retraction VPs have no credentials so they never matched itscredentialSubject.idfilter.🤖 Generated with Claude Code