Backport: Fix Vault e2e test startup race to V6.2#4200
Merged
Conversation
Probably due to a new version of vault, the e2e test failed. Vault tried to set setcap in vault container for CI compatibility which is not allowed by the CI runner. Created the correct container dependencies and skip the setcap for vault fixed the problem.
reinkrul
requested review from
gerardsn,
stevenvegt and
woutslakhorst
as code owners
April 16, 2026 11:24
stevenvegt
approved these changes
Apr 16, 2026
Contributor
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #4198 to V6.2.
The vault e2e test was failing because vault's entrypoint tries to call
setcapon the binary, which CI runners don't allow (CAP_SETFCAPnot granted). The fix:SKIP_SETCAP=trueon the vault container (mlock isn't required for dev mode anyway).depends_on: service_healthychains so the node waits for the adapter (which transitively waits for vault).--wait vault && sleep 2race with--wait vault-adapter.No release notes change needed.
Test plan
🤖 Generated with Claude Code