Skip to content

refactor(auth): remove non-conformant Display from issuer metadata #4347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reinkrul merged 1 commit into from
Jun 30, 2026
Merged

refactor(auth): remove non-conformant Display from issuer metadata #4347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions auth/api/iam/openid4vci_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ func TestWrapper_RequestOpenid4VCICredentialIssuance(t *testing.T) {
CredentialIssuer: "issuer",
CredentialEndpoint: "endpoint",
AuthorizationServers: []string{authServer},
Display: nil,
}
authzMetadata := oauth.AuthorizationServerMetadata{
AuthorizationEndpoint: "https://auth.server/authorize",
Expand Down Expand Up @@ -126,7 +125,6 @@ func TestWrapper_RequestOpenid4VCICredentialIssuance(t *testing.T) {
CredentialIssuer: "issuer",
CredentialEndpoint: "endpoint",
AuthorizationServers: []string{}, // empty
Display: nil,
}
ctx.openid4vciClient.EXPECT().OpenIDCredentialIssuerMetadata(nil, issuerClientID).Return(&metadata, nil)
ctx.iamClient.EXPECT().AuthorizationServerMetadata(nil, issuerClientID).Return(nil, assert.AnError)
Expand Down
9 changes: 4 additions & 5 deletions auth/openid4vci/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,10 @@ const JWTTypeOpenID4VCIProof = "openid4vci-proof+jwt"
// (Section 12.2). The document is OpenID4VCI-defined; it is not an OAuth
// authorization-server metadata document.
type OpenIDCredentialIssuerMetadata struct {
CredentialIssuer string `json:"credential_issuer"`
CredentialEndpoint string `json:"credential_endpoint"`
NonceEndpoint string `json:"nonce_endpoint,omitempty"`
AuthorizationServers []string `json:"authorization_servers,omitempty"`
Display []map[string]string `json:"display,omitempty"`
CredentialIssuer string `json:"credential_issuer"`
CredentialEndpoint string `json:"credential_endpoint"`
NonceEndpoint string `json:"nonce_endpoint,omitempty"`
AuthorizationServers []string `json:"authorization_servers,omitempty"`
}

// NonceResponse is the body returned by the Nonce Endpoint (Section 7.2).
Expand Down
Loading