Conversation
|
Hoping this PR goes out soon! 🤞🤞🤞 @danielroe @pi0 i'll buy you both a beer 😝 |
|
Hi @danielroe @pi0, is there any plan to merge this PR on future? I'm facing the issue with |
|
Is there any movement for this? We'd love to see that sooner - for our APP see all chunks preloaded is really a blocker. |
Member
|
@danielroe is working on final rewrite items to release as a major version 🚀 |
This was referenced Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ended up being a little more than I had intended. In short, it:
shouldPrefetchpublicPathto a function (buildAssetsURL) that is responsible for returning the public path of an asset - currently on rendererContext but it could easily be moved to ssrContext if we want per-request capability_dynamicEntrypointscacherenderResourceHeaders)Closes #28, resolves #20, resolves #24.
Breaking changes
shouldPrefetchandshouldPreloadnow have a different function type:(resource: ParsedResource) => booleancreateBundleRunnerintegration has been removednormalizeClientManifestwhich can be imported fromvue-bundle-renderer/legacy)clientManifestandpublicPathoptions can no longer be provided tocreateRenderer