fix: composable loosing contexts during tests#639
Open
HaNdTriX wants to merge 1 commit intonuxt-modules:v5from
Open
fix: composable loosing contexts during tests#639HaNdTriX wants to merge 1 commit intonuxt-modules:v5from
HaNdTriX wants to merge 1 commit intonuxt-modules:v5from
Conversation
✅ Deploy Preview for apollo-module canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
This PR removes
@vue/apollo-composablefromnuxt.options.build.transpile.Adding
@vue/apollo-composabletonuxt.options.build.transpilecauses all kinds of bugs since the module might be imported & executed twice.nuxt.options.build.transpile(here)This causes some composables (e.g.
useQueryoruseMutation) to loose context (currentApolloClients) in specific scenarios.One such scenario is running vitest & @nuxt/test-utils test with
useQueryoruseMutation: