[Help needed] Nuxt 3 support by Redemption198 · Pull Request #119 · nuxt-modules/device

Redemption198 · 2022-05-19T09:52:18Z

This is my first module so probably something isn't correct, I ported the device module to Nuxt 3 by rewriting it from scratch using the old code and the module starter from CLI, it should behave like the old one.

What's missing:

~~Tests~~
~~Publication workflow~~
~~Nuxt 2/Bridge support~~ (Marked as supported, needs to be tested)
(^ I don't have experience with these ^)
New readme information

Also added docs to the module config parameters

thoth3x · 2022-06-27T09:05:15Z

Hi,

When I pull your code the only thing that get pulled is README.md, package.json and LICENSE

I've tried with:

npm install git+https://github.com/Redemption198/device-module#master

npm install nuxt-community/device-module#pull/119/head:master (and variations without the head part)

also pulled the original @nuxt/device and then tried git fetch origin pull/119/head:master in it

but all with the same result

Any idea how to get all files?

Thank you!

Redemption198 · 2022-06-27T09:52:01Z

Hi,

When I pull your code the only thing that get pulled is README.md, package.json and LICENSE

I've tried with:

npm install git+https://github.com/Redemption198/device-module#master

npm install nuxt-community/device-module#pull/119/head:master (and variations without the head part)

also pulled the original @nuxt/device and then tried git fetch origin pull/119/head:master in it

but all with the same result

Any idea how to get all files?

Thank you!

Nothing appears because the module usually is built and uploaded to npm so the build files are ignored by Git. I built the module and temporarily included the build files, if you install it again it should work.

~~TypeScript autocomplete seems to not be working currently (inside the module playground it did) everything else should work fine.~~

Update: TypeScript autocomplete works with the latest commit.

nathanchase · 2022-08-13T02:50:10Z

Would love to see this merged in as a next branch. There is a need for the module to be production-ready for Nuxt 3.

nathanchase · 2022-09-06T11:29:44Z

This module will need an update to work with Nuxt 3 rc-9 and above. Currently in 3.0.0-rc.9 it gives the following error:

WARN  Module device-module is disabled due to incompatibility issues:  [nuxt] Nuxt version `^3.0.0 || ^2.16.0` is required but currently using '3.0.0-rc.9'

This is due to nuxt/framework#7116

Redemption198 · 2022-09-06T11:58:01Z

This module will need an update to work with Nuxt 3 rc-9 and above. Currently in 3.0.0-rc.9 it gives the following error:
WARN  Module device-module is disabled due to incompatibility issues:  [nuxt] Nuxt version `^3.0.0 || ^2.16.0` is required but currently using '3.0.0-rc.9'
This is due to nuxt/framework#7116

Thanks for the solution, the module has been updated to RC9.

robinscholz · 2022-10-06T09:23:33Z

+1 for releasing this under a next branch

TheAlexLichter · 2022-10-13T16:03:04Z

Thank you for your PR! 🙏

TheAlexLichter

Left some remarks ☺️

TheAlexLichter · 2022-10-17T09:08:13Z

@@ -0,0 +1,5 @@
+module.exports = function(...args) {


Any reason why you push the dist folder Ideally this will be auto-generated and only available on NPM.

You're correct, that was intentional because as requested here, people were trying to install it from GitHub. It wasn't included when I opened this PR, but 5 months passed and no one from this repository showed up so I temporarily included it.

Ahh, got it 👍🏻
Yes, that makes sense - alternatively feel free to publish a temp package so people can use that while the PR is pending 😋

TheAlexLichter · 2022-10-17T09:09:26Z

@@ -1,12 +0,0 @@
-const fetch = require('node-fetch')


Why removing the generation script here?

Honestly I have no idea, maybe it wasn't needed to make the module work so I forgot about it, I've restored it.

The idea was supposedly to have an easy way to generate the browser regexes so it isn't necessary to do it manually 😋

TheAlexLichter · 2022-10-17T09:09:50Z

+    name: 'device-module',
+    configKey: 'device',
+    compatibility: {
+      nuxt: '^3.0.0-rc.11 || ^2.16.0',


If it is compatible with previous RCs, I'd suggest to use a lower version (lowest compatible one)

Lowered to RC5.

TheAlexLichter · 2022-10-17T09:10:25Z

+  },
+  setup (options, nuxt) {
+    if (options.enabled) {
+      nuxt.options.runtimeConfig.public.device = defu(nuxt.options.runtimeConfig.public.device, {


Not necessary to merge options manually ☺️ You can skip that block

Thanks I removed it, I put it because I saw it in other Nuxt modules, as I said in the PR description this is my first module so I don't have the experience and the guides aren't much beginner friendly.

More than understandable. Does/did the module author guide help you?

It kinda did, maybe 5 months ago something was missing or wasn't explained clearly, I've checked it again and it seems fine.

I was trying to implement the tests, and noticed that the removal of the merge options prevents the plugin to access the module options.

Inside ./src/runtime/plugin.ts accessing useRuntimeConfig().public returns an empty object.

Ohh, sorry. My bad! Didn't read correctly and thought you merge the options themself, not the runtimeConfig.

So, ignore what I said and feel free to reintroduce the changes 🙈

TheAlexLichter · 2022-10-17T09:25:24Z

cc @danielroe, would really like to have your opinion on the PR too ☺️

TheAlexLichter · 2022-10-17T10:04:45Z

Regarding tests: I suppose that Nuxt's test-utils will come in handy - but I am not sure how easy it will be to "fake" the user agent for tests 🙈

…sion to RC5" This reverts commit 84b575e.

Redemption198 · 2022-10-17T17:45:43Z

Regarding tests: I suppose that Nuxt's test-utils will come in handy - but I am not sure how easy it will be to "fake" the user agent for tests see_no_evil

I found a way to recreate the old tests with Nuxt test utils, it isn't elegant but seems to be working.

TheAlexLichter · 2022-11-04T14:39:44Z

LGTM! cc @dotneet

dotneet · 2022-11-12T04:05:29Z

@Redemption198 Thank you for your great work!

dotneet · 2022-11-12T04:53:52Z

@Redemption198 3.0.0 has been released to npm!

Redemption198 · 2022-11-12T18:34:12Z

@Redemption198 3.0.0 has been released to npm!

Nice!

Redemption198 added 2 commits May 19, 2022 11:27

Nuxt 3 port

4622cb8

Update nuxt.config.ts

37e476c

Redemption198 mentioned this pull request May 24, 2022

Is there any possibility to use this module with nuxt3 composition api? #116

Closed

Added Nuxt Bridge Compatibility

2e32246

Also added docs to the module config parameters

Redemption198 added 2 commits June 27, 2022 11:27

(chore): update Nuxt to RC4

749963f

(chore): build module (temporarily)

3676fe3

Redemption198 added 9 commits July 3, 2022 11:09

(feat): add isApple flag

9c543e2

(fix): typescript types location

fab8b95

(fix): typescript $device types

6113034

(test) fix typescript support

261aae1

(fix): TypeScript autocomplete

1e92fe2

Remove unused hook

852dbdd

(chore): update Nuxt to RC5

54cacee

(chore): prepack the module

01d736e

(chore): update Nuxt to RC6

6c17aff

(chore): update Nuxt to RC8

d6d0b92

(chore): update Nuxt to RC9

fef752e

Redemption198 added 3 commits September 14, 2022 21:21

Update to Nuxt RC10

0ef0b3c

Update to Nuxt RC11

fe7ebba

Use slice instead of substr (deprecated)

f9d0477

Redemption198 mentioned this pull request Oct 6, 2022

Fail with Nuxt 3 RC 9 #122

Closed

Redemption198 added 3 commits October 6, 2022 18:06

Add useDevice() composable

7e78f87

Update README.md

4a57c2d

Update @nuxt/kit to RC11

850f283

thamudi reviewed Oct 12, 2022

View reviewed changes

Comment thread dist/runtime/plugin.mjs Outdated

TheAlexLichter suggested changes Oct 17, 2022

View reviewed changes

Redemption198 added 2 commits October 17, 2022 11:38

Restore bot-regex script

3108fe4

Remove unnecessary options merge and lowered minimum Nuxt version to RC5

84b575e

Redemption198 added 2 commits October 17, 2022 15:59

Revert "Remove unnecessary options merge and lowered minimum Nuxt ver…

bdf92a8

…sion to RC5" This reverts commit 84b575e.

Added Tests

78bf0cf

Bump deps

2136ea0

TheAlexLichter approved these changes Oct 28, 2022

View reviewed changes

Redemption198 added 5 commits November 4, 2022 15:19

Restore test workflow and publish scripts, remove dist

e81cb35

Update package.json

3f6767b

Update test.yaml

772c5f7

Update package.json

bbc5599

Update package.json

350f6bc

Update package.json

1d79565

dotneet merged commit b0018b4 into nuxt-modules:master Nov 12, 2022

Conversation

Redemption198 commented May 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thoth3x commented Jun 27, 2022

Uh oh!

Redemption198 commented Jun 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nathanchase commented Aug 13, 2022

Uh oh!

nathanchase commented Sep 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Redemption198 commented Sep 6, 2022

Uh oh!

robinscholz commented Oct 6, 2022

Uh oh!

Uh oh!

TheAlexLichter commented Oct 13, 2022

Uh oh!

TheAlexLichter left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Redemption198 Oct 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheAlexLichter Oct 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheAlexLichter commented Oct 17, 2022

Uh oh!

TheAlexLichter commented Oct 17, 2022

Uh oh!

Redemption198 commented Oct 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheAlexLichter commented Nov 4, 2022

Uh oh!

dotneet commented Nov 12, 2022

Uh oh!

dotneet commented Nov 12, 2022

Uh oh!

Redemption198 commented Nov 12, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Redemption198 commented May 19, 2022 •

edited

Loading

Redemption198 commented Jun 27, 2022 •

edited

Loading

nathanchase commented Sep 6, 2022 •

edited

Loading

Redemption198 Oct 17, 2022 •

edited

Loading

TheAlexLichter Oct 17, 2022 •

edited

Loading

Redemption198 commented Oct 17, 2022 •

edited

Loading