Skip to content

fix: revert to static dir#316

Merged
danielroe merged 1 commit intomainfrom
fix/static-dir
May 6, 2022
Merged

fix: revert to static dir#316
danielroe merged 1 commit intomainfrom
fix/static-dir

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

resolves #312

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We hard-coded public when processing layers. I'm also removing support for dir.public as I can't think this would be a useful thing to support when it would be unsupported by the rest of the project.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Apr 20, 2022
@danielroe danielroe requested a review from pi0 April 20, 2022 20:03
@danielroe danielroe self-assigned this Apr 20, 2022
This was referenced May 1, 2022
@danielroe danielroe merged commit 73f572d into main May 6, 2022
@danielroe danielroe deleted the fix/static-dir branch May 6, 2022 10:43
@danielroe danielroe mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

when use nirto in dev mode, static dir changed

1 participant