Skip to content

fix(types): allow head configuration as function#420

Merged
danielroe merged 1 commit intonuxt:mainfrom
dargmuesli:patch-1
Jul 18, 2022
Merged

fix(types): allow head configuration as function#420
danielroe merged 1 commit intonuxt:mainfrom
dargmuesli:patch-1

Conversation

@dargmuesli
Copy link
Copy Markdown
Member

🔗 Linked issue

#419

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Taken from https://github.com/nuxt/nuxt.js/blob/4ae7c089cb12fae5ed128ffad2c308da8e44c22e/packages/types/config/head.d.ts#L9.
Also: is the TODO comment two lines above still needed? I saw that the import is now taken from schema and not kit anymore.
Resolves #419.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Copy Markdown
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@danielroe danielroe merged commit 42ea75b into nuxt:main Jul 18, 2022
@dargmuesli dargmuesli deleted the patch-1 branch August 8, 2022 12:37
@danielroe danielroe mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

head configuration typing does not allow for a function

2 participants