Skip to content

fix: remove auto-imports that are not exported from vue#431

Merged
danielroe merged 1 commit intomainfrom
fix/auto-imports
Jul 20, 2022
Merged

fix: remove auto-imports that are not exported from vue#431
danielroe merged 1 commit intomainfrom
fix/auto-imports

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

resolves #426

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Previously we were using a shared auto-imports module between nuxt 3 + bridge. That led to some incompatibility, such as trying to filter vue 3 keys down to ones supported by vue 2 composition api. There's no need for this. Instead we can directly support only the keys of vue 2 that we want to auto-import.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

removes workaround for nuxt 3 auto-imports module
@danielroe danielroe added the bug Something isn't working label Jul 20, 2022
@danielroe danielroe requested a review from antfu July 20, 2022 13:59
@danielroe danielroe self-assigned this Jul 20, 2022
@danielroe danielroe changed the title fix: remove imports that are not exported from vue fix: remove auto-imports that are not exported from vue Jul 20, 2022
@danielroe danielroe merged commit e7a7f9b into main Jul 20, 2022
@danielroe danielroe deleted the fix/auto-imports branch July 20, 2022 19:50
@danielroe danielroe mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

export was not found in 'vue'

1 participant