Skip to content

fix: low browser support#434

Merged
danielroe merged 9 commits intonuxt:mainfrom
poyoho:fix/low-browser
Aug 2, 2022
Merged

fix: low browser support#434
danielroe merged 9 commits intonuxt:mainfrom
poyoho:fix/low-browser

Conversation

@poyoho
Copy link
Copy Markdown
Contributor

@poyoho poyoho commented Jul 21, 2022

🔗 Linked issue

compatible with lower version browsers. ?.

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Copy Markdown
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change. 👍

However, we are currently discussing whether to move Nuxt Bridge to support modern formats only, which will possibly mean a hard break with IE11: #15.

I think I'd be happy to merge this until (if) we get to that point, but wdyt @pi0?

@pi0
Copy link
Copy Markdown
Member

pi0 commented Jul 25, 2022

Current/Nuxt2 baseline for modern is supporting modules (Chrome and FF ~60) and optional chaining is more recent (chrome 80 and FF 74).

I think it is worth checking how many other libraries need to transform to make this happen. If this only change makes compatibility, I think it worth.

Comment thread src/vite/templates.ts Outdated
@poyoho
Copy link
Copy Markdown
Contributor Author

poyoho commented Jul 25, 2022

the app plugin must be using. It better to move it to Object.defineProperty?

And the useRuntimeConfig is seems can to move to Object.defineProperty.

@pi0
Copy link
Copy Markdown
Member

pi0 commented Jul 25, 2022

@poyoho Please make sure to check MDN for browser support. The lowest browser we can aim for bridge is chrome and firefox ~60 that support module scripts. They both support Proxy on an earlier version. More precise chart: https://caniuse.com/es6-module-dynamic-import

@poyoho
Copy link
Copy Markdown
Contributor Author

poyoho commented Jul 25, 2022

But ie no support it https://caniuse.com/?search=proxy 👀. And module scripts can folyfill by systemjs but the proxy can't to polyfill.

@pi0
Copy link
Copy Markdown
Member

pi0 commented Jul 25, 2022

Yes. We won't support internet explorer with a bridge. The least base line for bridge is browsers listed in https://caniuse.com/es6-module-dynamic-import. (Currently

And module scripts can folyfill by systemjs but the proxy can't to polyfill.

As daniel mentioned, we plan to target modern browsers only without polyfills. There are more and more underlying libraries setting this baseline and using new features such as Proxies.

@poyoho
Copy link
Copy Markdown
Contributor Author

poyoho commented Jul 25, 2022

@pi0 It better to declare in the document 😅. The lowest browser we can using bridge is chrome and firefox ~60

Comment thread README.md Outdated
Co-authored-by: Daniel Roe <daniel@roe.dev>
@poyoho
Copy link
Copy Markdown
Contributor Author

poyoho commented Aug 2, 2022

when It plan to release?

@danielroe danielroe merged commit c87fdbe into nuxt:main Aug 2, 2022
@poyoho poyoho deleted the fix/low-browser branch August 2, 2022 05:54
@danielroe
Copy link
Copy Markdown
Member

Thank you! ❤️ This should now be available on edge releases.

@danielroe danielroe mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants