Skip to content

fix(types): deduplicate types#469

Merged
danielroe merged 1 commit intonuxt:mainfrom
dargmuesli:fix/2-type-files
Aug 8, 2022
Merged

fix(types): deduplicate types#469
danielroe merged 1 commit intonuxt:mainfrom
dargmuesli:fix/2-type-files

Conversation

@dargmuesli
Copy link
Copy Markdown
Member

🔗 Linked issue

#437

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  • Remove unused type file
  • apply previous fix to used type file
  • remove todo comment (does look outdated or should be a github issue instead)

Resolves #437.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Copy Markdown
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this looks good to me ❤️

@danielroe danielroe merged commit 80ccd51 into nuxt:main Aug 8, 2022
@dargmuesli dargmuesli deleted the fix/2-type-files branch August 8, 2022 13:53
@danielroe danielroe mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There are 2 type files?

2 participants