fix: handle functional generate.routes#475
Merged
Conversation
pi0
reviewed
Aug 12, 2022
| delete nitroConfig.alias['#build'] | ||
|
|
||
| if (nuxt.options.generate.routes instanceof Function) { | ||
| console.warn('It is recommended to migrate the `generate.routes` function to the `nitro:config` hook instead. See https://github.com/nuxt/bridge/pull/475.') |
Member
There was a problem hiding this comment.
We might intoroduce better nitro hook (in prerender: namespace) to allow extending async hooks. nitro:config is also for dev and nornal build.
Member
Author
There was a problem hiding this comment.
Agreed - I think it would be good to have such a hook. Updating this section to avoid calling it in dev/prepare.
ad6b951 to
2f3a2bb
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #472
❓ Type of change
📚 Description
Users who want to programmatically determine what routes should be prerendered should use a hook to do so:
In the mean time, for backward compatibility, we can call the
generate.routesfunction.📝 Checklist