Skip to content

fix: improve types and use relative imports for composables#532

Merged
danielroe merged 2 commits intomainfrom
fix/composables
Sep 13, 2022
Merged

fix: improve types and use relative imports for composables#532
danielroe merged 2 commits intomainfrom
fix/composables

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This should improve stability of vite implementation and also improve type support somewhat - I was getting hanging in dev mode in a separate PR owing to circular composable references.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Sep 13, 2022
@danielroe danielroe self-assigned this Sep 13, 2022
@danielroe danielroe merged commit b03ca40 into main Sep 13, 2022
@danielroe danielroe deleted the fix/composables branch September 13, 2022 22:33
@danielroe danielroe mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant