Skip to content

fix: correct test for isFullStatic in legacy composition api#731

Merged
danielroe merged 5 commits intonuxt:mainfrom
wattanx:issue-730-capi-legacy-usefetch
May 2, 2023
Merged

fix: correct test for isFullStatic in legacy composition api#731
danielroe merged 5 commits intonuxt:mainfrom
wattanx:issue-730-capi-legacy-usefetch

Conversation

@wattanx
Copy link
Copy Markdown
Collaborator

@wattanx wattanx commented Apr 2, 2023

🔗 Linked issue

#730

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

In the case of nuxt start, process.static always seems to be true. Therefore, it generates global.mjs like @nuxtjs/composition-api and outputs isFullStatic.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx marked this pull request as ready for review April 3, 2023 03:27
Comment thread packages/bridge/src/runtime/capi.legacy.ts
@wattanx wattanx changed the title Backport isFullStatic from @nuxtjs/composition-api. fix: Backport isFullStatic from @nuxtjs/composition-api. Apr 5, 2023
@danielroe danielroe changed the title fix: Backport isFullStatic from @nuxtjs/composition-api. fix: correct test for isFullStatic in legacy composition api May 2, 2023
@danielroe danielroe merged commit e88ad64 into nuxt:main May 2, 2023
@wattanx wattanx deleted the issue-730-capi-legacy-usefetch branch May 3, 2023 03:01
@danielroe danielroe mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants