Skip to content

fix: write components.d.ts to correct path#758

Merged
danielroe merged 2 commits intonuxt:mainfrom
wattanx:issue-622-fix-components-type-path
May 5, 2023
Merged

fix: write components.d.ts to correct path#758
danielroe merged 2 commits intonuxt:mainfrom
wattanx:issue-622-fix-components-type-path

Conversation

@wattanx
Copy link
Copy Markdown
Collaborator

@wattanx wattanx commented May 5, 2023

🔗 Linked issue

#622

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

components.d.ts is being generated, but the path for nuxt.d.ts is set to types/components.d.ts.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Copy Markdown
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@danielroe danielroe changed the title fix: components.d.ts path fix: write components.d.ts to correct path May 5, 2023
@danielroe danielroe merged commit ab449e5 into nuxt:main May 5, 2023
@wattanx wattanx deleted the issue-622-fix-components-type-path branch May 5, 2023 15:06
@wattanx
Copy link
Copy Markdown
Collaborator Author

wattanx commented May 6, 2023

@danielroe
Due to the change to types/components.d.ts, it was necessary to modify the path to the component files (which I overlooked). Should I correct it to work with the types/components.d.ts path as intended?
https://github.com/nuxt/bridge/blob/main/packages/bridge/src/type-templates.ts#L18-L23

Or should I revert it back to components.d.ts and leave the path to the component files as-is?

@danielroe
Copy link
Copy Markdown
Member

I would keep it in types/ directory for consistency with the other files, and update the relative to be the typesDir not the buildDir.

@wattanx wattanx mentioned this pull request May 7, 2023
7 tasks
@danielroe danielroe mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants