Skip to content

fix: add server:devHandler hook for webpack#772

Merged
danielroe merged 2 commits intonuxt:mainfrom
wattanx:issue-607-add-server-dev-handler-hook
May 16, 2023
Merged

fix: add server:devHandler hook for webpack#772
danielroe merged 2 commits intonuxt:mainfrom
wattanx:issue-607-add-server-dev-handler-hook

Conversation

@wattanx
Copy link
Copy Markdown
Collaborator

@wattanx wattanx commented May 15, 2023

🔗 Linked issue

#607, #620

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I will port the devMiddleware settings from Nuxt 3.
https://github.com/nuxt/nuxt/blob/26c653128201526168172da2892aea052c486d1e/packages/webpack/src/webpack.ts#L109-L114

How to confirm

#607
Please set it as follows:

// nuxt.config.ts

export default defineNuxtConfig({
  ssr: true,
  bridge: {
    nitro: true
  }
})

#620
Please set it as follows:

// nuxt.config.ts

export default defineNuxtConfig({
  ssr: false,
  bridge: {
    nitro: true
  }
})

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx marked this pull request as ready for review May 16, 2023 11:59
Copy link
Copy Markdown
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@danielroe danielroe changed the title fix: add server:devHandler hook fix: add server:devHandler hook for webpack May 16, 2023
@danielroe danielroe merged commit 239ec24 into nuxt:main May 16, 2023
@danielroe danielroe mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants