feat: port upstream vite-node dev server implementation#779
Merged
feat: port upstream vite-node dev server implementation#779
vite-node dev server implementation#779Conversation
wattanx
force-pushed
the
upstream-vite-node
branch
from
38bbbd4 to
63fcab2
Compare
wattanx
force-pushed
the
upstream-vite-node
branch
from
63fcab2 to
73a1531
Compare
Member
|
In general it looks good to me. Can you point me out the changes you made to the original code when doing that port, if any? It would be helpful to review. Thanks |
This reverts commit f01f873.
wattanx
commented
Jun 9, 2023
Collaborator
Author
wattanx
left a comment
wattanx
left a comment
There was a problem hiding this comment.
I commented on the changes made from the original code!
Comment on lines
+112
to
+113
| 'entry.mjs': { | ||
| file: 'entry.mjs', |
Collaborator
Author
There was a problem hiding this comment.
Changes made to original code.
original code is
[ctx.entry]: {
file: ctx.entry
}| // Build and watch | ||
| const _doBuild = async () => { | ||
| const start = Date.now() | ||
| const { code, ids } = await bundleRequest(options, '/.nuxt/entry.mjs') |
Collaborator
Author
There was a problem hiding this comment.
Changes made to original code.
original code is
const { code, ids } = await bundleRequest(options, ctx.entry)
Comment on lines
+164
to
+166
| 'entry.mjs': { | ||
| isEntry: true, | ||
| file: 'entry.mjs', |
Collaborator
Author
There was a problem hiding this comment.
Changes made to original code.
original code is
[ctx.entry]: {
isEntry: true, // no change
file: ctx.entry
}| // Build and watch | ||
| const _doBuild = async () => { | ||
| const start = Date.now() | ||
| const { code, ids } = await bundleRequest(options, '/.nuxt/server.js') |
Collaborator
Author
There was a problem hiding this comment.
Changes made to original code.
original code is
const { code, ids } = await bundleRequest(options, ctx.entry)
danielroe
approved these changes
Jun 20, 2023
danielroe
changed the title
vite-node dev server implementation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
I will port vite-node-server from Nuxt 3.
📝 Checklist