fix: set router.base to app.baseURL#830
Merged
Conversation
Member
|
Nuxt 2 has a very early concept of and here: Maybe it would be worth respecting that instead? |
Collaborator
Author
|
Sorry, this implementation does not work with webpack and |
This reverts commit e96fbe1.
Collaborator
Author
|
There is some processing that depends on |
danielroe
approved these changes
Jul 4, 2023
router.base to app.baseURL
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolve: #16
resolve: #790
❓ Type of change
📚 Description
Nuxt 2's
router.basemust useapp.baseURLin Nuxt 3 and Nuxt Bridge.Fixed the
app.baseURLvalue to be set to_app.basePath, since the Nuxt 2 router must also be configured when usingapp.baseURL.(Without this modification, both
app.baseURLandrouter.basemust be set.)📝 Checklist