Skip to content

feat: Fixed so that head is rendered server-side.#838

Merged
danielroe merged 7 commits intonuxt:mainfrom
wattanx:feat-define-nuxt-component
Jul 29, 2023
Merged

feat: Fixed so that head is rendered server-side.#838
danielroe merged 7 commits intonuxt:mainfrom
wattanx:feat-define-nuxt-component

Conversation

@wattanx
Copy link
Copy Markdown
Collaborator

@wattanx wattanx commented Jun 27, 2023

🔗 Linked issue

Fixes: #868

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

In Nuxt 3, if ssr: true, the head of the defineNuxtComponent is rendered server-side.
I would like to support it in Nuxt Bridge.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx changed the title feat: impl defineNuxtComponent feat: upstream defineNuxtComponent Jun 30, 2023
@wattanx wattanx changed the title feat: upstream defineNuxtComponent fix: head and useHead can be used with defineNuxtComponent Jul 22, 2023
@wattanx wattanx marked this pull request as ready for review July 22, 2023 08:45
@wattanx wattanx changed the title fix: head and useHead can be used with defineNuxtComponent fix: Fixed defineNuxtComponent head to work with SSR Jul 22, 2023
@wattanx wattanx changed the title fix: Fixed defineNuxtComponent head to work with SSR feat: Fixed defineNuxtComponent head to work with SSR Jul 22, 2023
@wattanx wattanx requested a review from danielroe July 22, 2023 09:25
@wattanx wattanx changed the title feat: Fixed defineNuxtComponent head to work with SSR feat: Fixed so that head is rendered server-side. Jul 22, 2023
@harlan-zw
Copy link
Copy Markdown
Contributor

lgtm

@danielroe danielroe merged commit 984ce7c into nuxt:main Jul 29, 2023
@danielroe danielroe mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

head of defineNuxtComponent is not rendered on the server side

3 participants