fix: do not inject imports within node_modules#873
Merged
Conversation
deleteme
reviewed
Jul 28, 2023
| expect(await transform('let ref = () => {}; const a = ref(0)')).to.equal(undefined) | ||
| expect(await transform('let { ref } = Vue; const a = ref(0)')).to.equal(undefined) | ||
| expect(await transform('let [\ncomputed,\nref\n] = Vue; const a = ref(0); const b = ref(0)')).to.equal(undefined) | ||
| }) |
Collaborator
Author
There was a problem hiding this comment.
I can't reproduce it and don't know what caused it, so I don't know if it will be fixed...
| // import { computed } from \\"foo\\" | ||
| ;const a = computed(0)" | ||
| `) | ||
| }) |
Contributor
There was a problem hiding this comment.
Is it worthwhile to add another assertion here that it can ignore block style comments?
Collaborator
Author
There was a problem hiding this comment.
I think it is worthwhile if block style comments are not ignored.
danielroe
approved these changes
Aug 3, 2023
danielroe
changed the title
node_modules
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Fixes: #870
❓ Type of change
📚 Description
I have fixed it so that it throws an error if autoImport: false as in Nuxt 3.
📝 Checklist