Skip to content

fix: mock new hookable methods#921

Merged
danielroe merged 2 commits intomainfrom
feat/mock-hook-methods
Oct 2, 2023
Merged

fix: mock new hookable methods#921
danielroe merged 2 commits intomainfrom
feat/mock-hook-methods

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This mocks three missing hook methods added in newer hookable.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Oct 2, 2023
@danielroe danielroe requested review from pi0 and wattanx October 2, 2023 11:39
@danielroe danielroe self-assigned this Oct 2, 2023
Copy link
Copy Markdown
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

(Also why we would benefit by refactoring more code to directly depend on nuxt.hooks to make sure similar forward compatibility is guaranteed in nuxt 3..)

Comment thread packages/bridge/module.cjs Outdated
@danielroe danielroe changed the title fix: mock hook methods for nuxi fix: mock new hookable methods Oct 2, 2023
@danielroe danielroe merged commit 84a8419 into main Oct 2, 2023
@danielroe danielroe deleted the feat/mock-hook-methods branch October 2, 2023 12:06
@wattanx
Copy link
Copy Markdown
Collaborator

wattanx commented Oct 2, 2023

Thank you ❤️

@danielroe danielroe mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants