Set a default value for the vscode host parameter#766
Merged
Conversation
Without this, the ms-code-cli will fail to start if the host isn't specified in nuxt config.
Contributor
Author
|
@antfu heads up - I found a bug in my changes, the ms-code-server and ms-code-cli options weren't working if a host wasn't specified. This sets a default value for the host (127.0.0.1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Fixes
❓ Type of change
📚 Description
Fixes a bug in #763 - when the host parameter is not specified, the MS Code Server and MS Code CLI won't start (empty parameter is unrecognized). This change defaults the host to 127.0.0.1.