This repository was archived by the owner on Apr 6, 2023. It is now read-only.
feat(vite): use externality to resolve externals for ssr dev bundler#1172
Merged
feat(vite): use externality to resolve externals for ssr dev bundler#1172
externality to resolve externals for ssr dev bundler#1172Conversation
|
✔️ Deploy Preview for nuxt3-docs canceled. 🔨 Explore the source changes: 46b0ac2 🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/616fd8b73b1f7c0007c6749d |
externality to resolve externals for viteexternality to resolve externals for ssr dev bundler
pi0
reviewed
Oct 18, 2021
Member
We have some detection system in jiti as well. I think worth doing it later and move logic to mlly and using in externality. |
pi0
reviewed
Oct 19, 2021
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
some context: nuxt/nuxt#11824
closes nuxt/nuxt#12219
❓ Type of change
📚 Description
This PR replaces the current externals check with one based on wp5's resolution algorithm using
externality.📝 Checklist