This repository was archived by the owner on Apr 6, 2023. It is now read-only.
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
approved these changes
Apr 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
The original warm-up will only warm up the entry module, due to two issues:
server.moduleGraph.urlToModuleMap.get(url)does not hit because we are warm-up with unresolved URLs, whileurlToModuleMapstores resolved absolute URL. UsegetModuleByUrl(url)will let Vite handles the normalization and matching./@id/__x00__for browser compatibility, while the plugin still expects the id starts with\0, causing thetransformRequestto returnundefinedand failed to identify it's dependencies (that means, all Vue components and user code)This PR improves the warm-up logic, and also fixes the FOUC problem of
vite-nodeand #3968